Remove legacy correlate, dot, and multiply from backend #2183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderKalistratov
requested review from
antonwolfy,
npolina4,
vlad-perevezentsev and
vtavana
as code owners
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2183/index.html |
AlexanderKalistratov
force-pushed
the
correlate
branch
from
0d6a4e0
to
9083eeb
Compare
AlexanderKalistratov
force-pushed
the
remove_dot_and_multiply_from_backend
branch
from
c0f0457
to
46762fa
Compare
AlexanderKalistratov
force-pushed
the
correlate
branch
from
9083eeb
to
8256472
Compare
AlexanderKalistratov
force-pushed
the
remove_dot_and_multiply_from_backend
branch
from
46762fa
to
2f51c9e
Compare
AlexanderKalistratov
force-pushed
the
correlate
branch
from
8256472
to
5f793ab
Compare
AlexanderKalistratov
force-pushed
the
remove_dot_and_multiply_from_backend
branch
2 times, most recently
from
d64c029
to
fd2a20d
Compare
AlexanderKalistratov
changed the title
AlexanderKalistratov
force-pushed
the
correlate
branch
from
5f793ab
to
2514037
Compare
AlexanderKalistratov
force-pushed
the
remove_dot_and_multiply_from_backend
branch
from
fd2a20d
to
e3feeef
Compare
AlexanderKalistratov
force-pushed
the
remove_dot_and_multiply_from_backend
branch
from
e3feeef
to
ca1b3ef
Compare
vtavana
reviewed
Nov 20, 2024
| parameters */ | ||
| DPNP_FN_ERF, /**< Used in scipy.special.erf impl */ | ||
| DPNP_FN_ERF_EXT, /**< Used in scipy.special.erf impl, requires extra | ||
| parameters */ |
There was a problem hiding this comment.
DPNP_FN_MULTIPLY below can be removed as well.
| @@ -62,7 +62,6 @@ include "dpnp_algo_indexing.pxi" | |||
| include "dpnp_algo_mathematical.pxi" | |||
| include "dpnp_algo_sorting.pxi" | |||
| include "dpnp_algo_special.pxi" | |||
| include "dpnp_algo_statistics.pxi" | |||
|
|
|||
|
|
|||
| cpdef dpnp_queue_initialize(): | |||
There was a problem hiding this comment.
It seems dpnp_queue_initialize can be removed as well.
| @@ -34,7 +34,6 @@ from dpnp.dpnp_utils.dpnp_algo_utils cimport dpnp_descriptor | |||
| cdef extern from "dpnp_iface_fptr.hpp" namespace "DPNPFuncName": # need this namespace for Enum import | |||
| cdef enum DPNPFuncName "DPNPFuncName": | |||
| DPNP_FN_CHOOSE_EXT | |||
| DPNP_FN_CORRELATE_EXT | |||
| DPNP_FN_ERF_EXT | |||
| DPNP_FN_MODF_EXT | |||
| DPNP_FN_PARTITION_EXT | |||
There was a problem hiding this comment.
fptr_2in_1out_t at the bottom of this file can be removed as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing
dotandmultiplyimplementations from backend as no longer needed.Depends on PR #2183