Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce DPNP_WITH_REDIST cmake option #2199

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Nov 26, 2024

The PR proposes to introduce DPNP_WITH_REDIST cmake options, defaulting to OFF.

If set, cmake script add to RUNPATH an entry relative to $ORIGIN that would point to $PREFIX/lib, hence allowing native extensions to find DPC++ redistributable libraries.

conda-recipe/build.sh is modified to set DPNP_WITH_REDIST=TRUE.

It closes #2200.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Nov 26, 2024
Copy link
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/2199/index.html

@ndgrigorian
Copy link
Contributor

I've checked both wheels installed from internal CI and from public CI and it seems to install and import dpnp correctly.

(pypi_venv) (py312) ngrigori@ngrigori-mobl:~$ pip install dpnp-0.17.0.dev2+26.g4e43c48aed8-cp312-cp312-manylinux_2_28_x86_64.whl
Processing ./dpnp-0.17.0.dev2+26.g4e43c48aed8-cp312-cp312-manylinux_2_28_x86_64.whl
Installing collected packages: dpnp
Successfully installed dpnp-0.17.0.dev2+26.g4e43c48aed8
(pypi_venv) (py312) ngrigori@ngrigori-mobl:~$ python -c "import dpnp"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dpnp installed into virtual env fails to import
2 participants