-
Notifications
You must be signed in to change notification settings - Fork 5
Extend INSTALL_RPATH to include parent directories #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This change ensures that shared libraries located in $ORIGIN, $ORIGIN/../.., and $ORIGIN/../../.. are discoverable at runtime, improving robustness in environments where dependent libraries may be installed outside the immediate directory
@vtavana I wanted to ask you if it makes sense to update this as well https://github.com/IntelPython/mkl_umath/blob/main/CMakeLists.txt#L143? |
Yes, I believe you have to do the same here for |
I'm going to test this change in the wheel. I'll let you know as soon as the results are available |
@ndgrigorian confirmed that the wheel built with this change is working correctly. I think we can merge this and create a new release. I also managed to install the package locally and reproduce the scenario, it works:
|
Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, resolves the issue when I tested with Python 3.11 and 3.12
This PR updates the INSTALL_RPATH for the _ufuncs target on Unix systems to improve runtime discovery of dependent shared libraries such as libintlc.so.5 (IntelPython/mkl_fft#146).
In recent builds (e.g., mkl_umath 0.1.4), users encountered runtime errors like:
Although the library was bundled with the wheel, it could not be located at runtime due to limited RPATH configuration.
The updated INSTALL_RPATH now includes additional parent directories. This allows the dynamic linker to resolve libraries located in upper-level paths relative to the extension module.