Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanups and name fixes #2759

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Cleanups and name fixes #2759

merged 1 commit into from
Jun 29, 2023

Conversation

SamerKhshiboun
Copy link
Collaborator

@SamerKhshiboun SamerKhshiboun commented May 30, 2023 •
edited
Loading

  • fix std::map vars names to plural
  • remove redundant parameters
  • remove unused code

@SamerKhshiboun SamerKhshiboun marked this pull request as ready for review June 29, 2023 08:31
Nir-Az
Nir-Az approved these changes Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nir-Az Nir-Az merged commit 68cc6fe into IntelRealSense:ros2-development Jun 29, 2023
@SamerKhshiboun SamerKhshiboun deleted the fix-code branch July 25, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nir-Az Nir-Az Nir-Az approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamerKhshiboun @Nir-Az