Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying AlignDepth filter after Pointcloud #2775

Merged

Conversation

Arun-Prasad-V
Copy link
Contributor

Fixing #2595.

Issue:

  • When both PointCloud and AlignDepth filters are enabled, the point cloud output has misaligned colored point cloud

Root cause:

  • First Align Depth filter process the frame and then Point Cloud filter uses the same processed frame and internally align again
  • That's why color is getting registered twice

Proposed Solution:

  • Apply the Point Cloud filter first
    • So, it will get the unprocessed frame and internally do the alignment
    • The alignment will only happen on point cloud's data and the original depth frame will be untouched
  • Then, apply the Align Depth filter
    • It will get the original depth frame and does the alignment

Copy link
Collaborator

@SamerKhshiboun SamerKhshiboun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@Nir-Az should we wait for user confirmation? or should we merge it ?

@Nir-Az Nir-Az merged commit bb71653 into IntelRealSense:ros2-development Jun 27, 2023
7 checks passed
@Nir-Az
Copy link
Collaborator

Nir-Az commented Jun 27, 2023

LGTM. @Nir-Az should we wait for user confirmation? or should we merge it ?

Since the last comment was 2 weeks ago and it was tested by us then we will merge and monitor the issue for user feedback :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants