Update _d585.urdf.xacro #2807
Merged
Update _d585.urdf.xacro #2807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates after new measurements of new model on solid work. Still need to be updated for every new engineering model.
Nir-Az
reviewed
Jul 6, 2023
| @@ -47,11 +47,11 @@ aluminum peripherial evaluation case. | |||
| <xacro:property name="d585_cam_depth" value="0.0931"/> | |||
|
|
|||
| <!-- TODO Samer: This parameter is still missing, took it from D455 --> | |||
| <xacro:property name="d585_cam_mount_from_center_offset" value="0.0377"/> <!-- TODO Samer: check --> | |||
| <xacro:property name="d585_cam_mount_from_center_offset" value="0.042"/> <!-- TODO Samer: check --> | |||
There was a problem hiding this comment.
We decided to keep these lines as long as we don't have the accurate numbers.
There was a problem hiding this comment.
I suggest comment this :)
Not final numbers, still require refinements
TODO Samer check means you are not sure and you need to check before it is merged :)
Nir-Az
approved these changes
Jul 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates after new measurements of new model on solid work. Still need to be updated for every new engineering model.