Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Triggered Calibration as ROS2 Action #3138

Merged

Conversation

SamerKhshiboun
Copy link
Collaborator

@SamerKhshiboun SamerKhshiboun commented Jun 22, 2024

Tracked on RSDEV-2204

Based on:
https://design.ros2.org/articles/actions.html
https://docs.ros.org/en/jazzy/Tutorials/Intermediate/Writing-an-Action-Server-Client/Cpp.html#writing-an-action-server

  • Added new action TriggeredCalibration
  • Updated README
  • Created new actions.cpp file and implemented the action in it
  • Added documentation.
  • Testing will be done in RSDEV-2298

@@ -0,0 +1,121 @@
// Copyright 2024 Intel Corporation. All Rights Reserved.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions.cpp is a generic name.
Do we want a calibration action dedicated name instead ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will add all actions in the future inside it (we can add FW-update action for example, etc..)
(In the same way, I will create a "services.cpp" file for all services - we can redesign this in a separate task)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On next action/service please consider creating a service/action folder and implement a file for each serve/action
With time it may grow..

@Nir-Az
Copy link
Collaborator

Nir-Az commented Jun 23, 2024

Looks great overall :)

@SamerKhshiboun SamerKhshiboun merged commit 598756b into IntelRealSense:ros2-development Jun 23, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants