Skip to content

Force-enable NETWORK side effect to ensure blocks are instantly visible#4558

Merged
NotMyFault merged 1 commit intomainfrom
fix/block-change-visibility
Dec 30, 2024
Merged

Force-enable NETWORK side effect to ensure blocks are instantly visible#4558
NotMyFault merged 1 commit intomainfrom
fix/block-change-visibility

Conversation

@SirYwell
Copy link
Copy Markdown
Member

Overview

Description

Fixes an issue where block changes depending on WNA weren't visible. This is initially caused by FAWE as it changes the NETWORK default to OFF. By just re-enabling it, we can restore the previous behavior.
As the NETWORK side effect is WE 7.3+, we fall back to ignoring it if not present.

### Submitter Checklist
- [x] Make sure you are opening from a topic branch (**/feature/fix/docs/ branch** (right side)) and not your main branch.
- [x] Ensure that the pull request title represents the desired changelog entry.
- [x] New public fields and methods are annotated with `@since TODO`.
- [x] I read and followed the [contribution guidelines](https://github.com/IntellectualSites/.github/blob/main/CONTRIBUTING.md).

@SirYwell SirYwell requested a review from a team as a code owner December 22, 2024 11:40
@github-actions github-actions Bot added the Bugfix This PR fixes a bug label Dec 22, 2024
@NotMyFault NotMyFault requested a review from a team December 24, 2024 11:34
@NotMyFault NotMyFault merged commit effbacb into main Dec 30, 2024
@NotMyFault NotMyFault deleted the fix/block-change-visibility branch December 30, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix This PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants