JSON support proposal, currently only for INSERT #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This is the beginning of a proposal/spec for supporting JSON. The goal was to reveal a pattern that can be applied to other Model and QueryBuilder methods. I'd like to get opinions before I commit to the remaining query methods.
Context
JSON support requires some sort of schema because it uses a
TEXT
column type, but requires additional context/knowledge that the column should be treated as JSON. With this in mind, the QueryBuilder has been updated to accept acolumns?
property in the options.Changes to note
json
boolean to theModelColumn
interface.columns
config to theGenerateQueryOptions
INSERT
andINSERT_OR_REPLACE
to check for a column config and give special treatment ifcolumn.json
is truthy.Model.InsertOne
method to passcolumns
in the options.I've run the code in wrangler dev to make sure it works in "production".