-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the function of select columns #68
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 072b2c2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
A minor change to match the SQLite standard would be wonderful. Please also run the changeset
and prettify
scripts 🙂
Understood, let me fix it. |
public async First( | ||
options: Pick<GenerateQueryOptions<InferFromColumns<T>>, "where"> | ||
options: Pick< | ||
GenerateQueryOptions<InferFromColumns<T>>, | ||
"where" | "columns" | ||
> | ||
): Promise<InferFromColumns<T> | null> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing I've realised is that when the user is specifying columns
, the return type of this method is going to be wrong - we'd only want to return the type for the columns which are being returned
There's not any particularly nice way to handle this though 🤔
No description provided.