feat: update to latest D1 Database interface #71
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The D1 Database
exec
method has changed an now expects aExecResult
instead of aResult<T>
. If you're using the latest@cloudflare/workers-types
, the ORM response will be incorrect for methods likeCreateTable
orDropTable
, which useexec
under the hood. This PR bumps to the latest version and makes slight changes to fix this return type.Details
The latest D1 APIs can be found here. The is what
exec
looks like:And
D1ExecResult
:The proposed changes simply swap out the outdated return type of
D1Result<T>
forD1ExecResult
where needed. Also,chai
was updated in order to fix an import issue in the tests.How it was tested
After updating these deps and making slight changes to
database.ts
andmodel.ts
, the tests pass without needing any changes.