Support Qwen3-VL #4093
Open
Support Qwen3-VL #4093
+1,258
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c979730.
3 tasks
lvhan028
reviewed
Nov 4, 2025
lvhan028
reviewed
Nov 4, 2025
lvhan028
reviewed
Nov 4, 2025
lvhan028
reviewed
Nov 4, 2025
lvhan028
reviewed
Nov 4, 2025
|
Improved the config check part, tested with internvl / intern-s1 / qwen3vl / qwen3 / qwen2.5vl / glm4.1v, seems good. |
lvhan028
previously approved these changes
Nov 4, 2025
|
May share the evalution test results |
grimoire
reviewed
Nov 5, 2025
| language_hf_config = config.hf_config | ||
|
|
||
| # for multi-modal models, get the language model config to determine dtype | ||
| if hasattr(config.hf_config, 'text_config'): |
There was a problem hiding this comment.
We have llm_config field in config.
grimoire
reviewed
Nov 5, 2025
| visual_embeds: torch.Tensor): | ||
| visual_pos_masks = visual_pos_masks.to(hidden_states.device) | ||
| visual_embeds = visual_embeds.to(hidden_states.device, hidden_states.dtype) | ||
| local_this = hidden_states[visual_pos_masks, :].clone() + visual_embeds |
There was a problem hiding this comment.
hidden_states[visual_pos_masks, :] would synchronize cuda device. Try:
local = torch.zeros_like(hidden_states)
local.masked_scatter_(visual_pos_masks, visual_embeds)
hidden_states += local
|
LLM evaluation test failed by following #4094 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
TODO