Fmaste/dmq node traces #5233

fmaste · 2025-10-27T17:12:49Z

Description

reasonably detailed description of the pull request

Checklist

Quality

Commit sequence makes sense and have useful messages, see ref.
New tests are added and existing tests are updated.
Self-reviewed the PR.

Maintenance

Linked an issue or added the PR to the current sprint of ouroboros-network project.
Added labels.
Updated changelog files.
The documentation has been properly updated, see ref.

A trace is emitted whenever a hot outbound peer is demoted or closed (possibly due to an error), giving the duration in seconds of how long the peer has been in hot mode. Added hot connection durations to peer selection debug state, which traces durations upon receiving sigusr1 interrupt.

…n-durations Trace connection durations

…n-durations restore tracking of hot connection durations when demoting a peer

ouroboros-network-0.22.1

Fixed quickcheck-monoids

ouroboros-network-0.22.2: bp defaults

Compatibility with QuickCheck-2.15

coot · 2025-10-31T14:49:15Z

network-mux/network-mux.cabal

+  hs-source-dirs: traces
+  visibility: public
+  exposed-modules:
+    Network.Mux.Traces


We already have a very similar module Network.Mux.Trace, what about Network.Mux.Trace.TraceDispatcher?

coot · 2025-10-31T14:53:01Z

network-mux/network-mux.cabal

    -Wredundant-constraints
    -Wunused-packages

+library traces


Suggested change

library traces

library trace-dispatcher-instances

coot · 2025-10-31T14:54:02Z

ouroboros-network/ouroboros-network.cabal

  if flag(txsubmission-delay)
    cpp-options: -DTXSUBMISSION_DELAY

+library traces


Suggested change

library traces

library trace-dispatcher-instances

coot · 2025-10-31T14:57:11Z

ouroboros-network/ouroboros-network.cabal

+  visibility: public
+  hs-source-dirs: traces
+  exposed-modules:
+    Ouroboros.Network.Traces


Suggested change

Ouroboros.Network.Traces

Ouroboros.Network.Trace.TraceDispatcher

coot · 2025-10-31T15:01:29Z

ouroboros-network-framework/ouroboros-network-framework.cabal

    -Wredundant-constraints
    -Wno-unticked-promoted-constructors

+library traces


In main, ouroboros-network-framework was integrated with ouroboros-network package, when you'll be rebasing, it might be a good idea to just put all the instances in a single package in ouroboros-network, even in a single module, since here there's just one orphan instance.

Maybe better place is cardano-diffusion package?

It won't work if it is needed in dmq-node.

We depend on cardano-diffusion in the dmq-node so we could get these instances from there, and keep ouroboros-network free from trace-dispatcher in case someone wants to use their own favorite tracing library with it? [edit] In my mind, things related to trace-dispatcher are cardano-specific, and ouroboros-network should be generic.

We depend on cardano-diffusion

We don't, at least it main, and that's good, ref.

I use connectTo from Cardano.Network.NodeToClient to establish a local connection to the Cardano node.

Then, no objection from me to put these traces in cardano-diffusion.

crocodile-dentist · 2025-11-05T13:25:10Z

network-mux/network-mux.cabal

    -Wredundant-constraints
    -Wunused-packages

+library traces


There's also an option to make this a separate package for eg. cardano-network-mux-trace since network-mux in principle is a very general library. Another benefit is that in case we make changes to the tracers we will not have to make a release of network-mux. What's your take @coot ?

Good point.

crocodile-dentist · 2025-11-05T13:26:11Z

ouroboros-network/ouroboros-network.cabal

  if flag(txsubmission-delay)
    cpp-options: -DTXSUBMISSION_DELAY

+library traces


Wouldn't cardano-diffusion be a better home for these instances?

It won't work if these instances are also needed in dmq-node.

crocodile-dentist · 2025-11-05T13:27:51Z

ouroboros-network-framework/ouroboros-network-framework.cabal

    -Wredundant-constraints
    -Wno-unticked-promoted-constructors

+library traces


Maybe better place is cardano-diffusion package?

coot · 2025-12-04T18:10:18Z

current location	suggested location	argument
`network-mux:cardano-logging`	`ouroboros-network:mux-logging`	we don't want `cardano-tracer` dependency in `network-mux`, since we plan to publish it on hackage as an independent library at some point
`ouroboros-network:cardano-logging`	OK	-
`ouroboros-network:framework-cardano-logging`	OK	-

@crocodile-dentist do you agree?

coot · 2025-12-08T09:16:00Z

I agree with @crocodile-dentist that we can simply put all these trace instances in a single sublibrary in cardano-diffusion.

crocodile-dentist and others added 16 commits July 24, 2025 12:13

changelog

1d0e44c

Merge pull request #5146 from IntersectMBO/mwojtowicz/track-connectio…

0961d35

…n-durations Trace connection durations

Restore tracking of 'PeerHotDuration' when demoting a peer

c7a45c7

Merge pull request #5168 from IntersectMBO/mwojtowicz/track-connectio…

ccb7ddb

…n-durations restore tracking of hot connection durations when demoting a peer

Retain original CBOR encoding of {Ledger}RelayAccessPoint

82df769

NodeToClientV_22: support SRV in GetLedgerPeerSnapshot

604013c

ouroboros-network-0.22.1

8300520

Merge pull request #5166 from IntersectMBO/coot/release-0.22

e307020

ouroboros-network-0.22.1

quickcheck-monoids: fixed a build error

e79d6af

Fixed quickcheck-monoids

98ee8d1

Merge pull request #5170 from IntersectMBO/coot/quickcheck-monoids-fix

7dadb41

Fixed quickcheck-monoids

Default values that depend on node role (BP/Relay)

198e84e

Merge pull request #5174 from IntersectMBO/coot/bp-defaults-0.22

3bdc028

ouroboros-network-0.22.2: bp defaults

quickcheck-monoids: compatibility with QuickCheck-2.16

751aaae

Merge pull request #5190 from IntersectMBO/coot/quickcheck-2.15

cb806d0

Compatibility with QuickCheck-2.15

github-project-automation bot added this to Ouroboros Network Oct 27, 2025

github-project-automation bot moved this to In Progress in Ouroboros Network Oct 27, 2025

fmaste force-pushed the fmaste/dmq-node-traces branch 3 times, most recently from e1a6963 to 4aaeabe Compare October 27, 2025 20:15

fmaste added 3 commits October 27, 2025 20:28

REMOVE ME

ed9f0e3

network-mux:traces

a3d81a1

ouroboros-network:traces

817dbff

fmaste force-pushed the fmaste/dmq-node-traces branch from 4aaeabe to 817dbff Compare October 27, 2025 20:28

ouroboros-network-framework:traces

3e27ce8

coot reviewed Oct 31, 2025

View reviewed changes

crocodile-dentist reviewed Nov 5, 2025

View reviewed changes

	Ouroboros.Network.Traces
	Ouroboros.Network.Trace.TraceDispatcher

Fmaste/dmq node traces #5233

Are you sure you want to change the base?

Fmaste/dmq node traces #5233

Conversation

fmaste commented Oct 27, 2025

Description

Checklist

Quality

Maintenance

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

crocodile-dentist Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coot commented Dec 4, 2025

Uh oh!

coot commented Dec 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

crocodile-dentist Dec 4, 2025 •

edited

Loading