Respect bootstrap peers timeout #5258
Open
+38
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
reviewed
Dec 10, 2025
Comment on lines
244
to
246
| -- ensure this is run in case when peer selection has nothing else | ||
| -- that can wake the governor up. | ||
| GuardedSkip $ Cardano.bootstrapPeersTimeout (extraState pst) |
Collaborator
There was a problem hiding this comment.
It would be better to add this to the guarded decision which actually needs to run. Isn't it this one waitForSystemToQuiesce?
Do we have a counter example to test it?
Contributor
Author
There was a problem hiding this comment.
I'll check for the test, if not I will write one.
crocodile-dentist
force-pushed
the
mw/bootstrap-timeout
branch
from
9cdaea9 to
7543fa3
Compare
crocodile-dentist
force-pushed
the
mw/bootstrap-timeout
branch
from
7543fa3 to
f9d9647
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure timeout to enter sensitive state when bootstrap peers are enabled is always respected.
Checklist
Quality
Maintenance
ouroboros-networkproject.