tx-sub: simple mempool writer changes #5264
Open
+131
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
reviewed
Dec 10, 2025
Collaborator
coot
left a comment
coot
left a comment
There was a problem hiding this comment.
LGTM, I would just remove the ctx from mempoolAddTxs, since this can be done outside of the mempoolAddTxs.
| -- ^ return `True` when a failure should throw an exception | ||
| -- ^ acquire validation context | ||
| -> ( [tx] | ||
| -> ctx |
Collaborator
There was a problem hiding this comment.
Could we remove the ctx, I realised at some point that we don't need inside it inside getWriter``: we acquire it in m ctx callback, which can be done outside of `getWriter` and passed to the validation callback. This will slightly simplify `getWriter`.
I should have cleaned this up before, so sorry for asking you to do that in this PR.
coot
requested changes
Dec 11, 2025
Comment on lines
205
to
206
| writerAdapter MempoolWriter { txId, mempoolAddTxs } = undefined | ||
| TxSubmissionMempoolWriter { txId, mempoolAddTxs = adapter } |
Collaborator
There was a problem hiding this comment.
This is not finished or just not needed undefined.
crocodile-dentist
force-pushed
the
mw/simple-mempool-writer
branch
from
e5a9064 to
b165a81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generalized mempool
getWriterto validate tx's in a given context and returning user defined validation errorsChecklist
Quality
Maintenance
ouroboros-networkproject.