[IP-939]: Implementing e-invoicing flow by nielsdrost7 · Pull Request #1103 · InvoicePlane/InvoicePlane

nielsdrost7 · 2024-10-30T07:53:48Z

Description

The IP user can select which e-invoice format is appropriate for their customer/country.
A pdf, and the appropriate e-invoice format, is then generated and sent to the client.

Related Issue

Feature Request #939 "Implement e-invoicing for UBL/CII formats (EN 16931, Zugferd/Factur-X, PEPPOL, etc...) other than only Zugferd"
See my comments in Feature Request 939.

Motivation and Context

Worldwide, and certainly in Europe, governments, clients and accountants are switching to electronic invoices.
e-Invoices can be used to process these documents machine readable and automatically.
XML templates can be created specifically for a country or client.
How to add an XML template is described in the "About e-Invoicing templates.md" file located in the "helpers/XMLconfigs/" folder.
I have added 2 XML template example files.
The (old) IP Zugferdv10Xml.php file serves as "CII format" example and the Ublexamv20Xml.php file serves as "UBL format" example.

Screenshots (if appropriate):

Template selection field on the client form page
Zugferd (CII) or EN16931 (UBL) format

Pull Request Checklist

My code follows the code formatting guidelines.
I have an issue ID for this pull request.
I selected the corresponding branch.
I have rebased my changes on top of the corresponding branch.

Issue Type (Please check one or more)

#939

Bugfix
Improvement of an existing Feature
New Feature

nielsdrost7 · 2024-10-30T07:56:19Z

@Verony-makesIT I've moved your Pull-Request over to the InvoicePlane repository.
After I'm done with the code-review, I'll let you know and then you can take a look at it as well

nielsdrost7 · 2024-10-31T07:08:56Z

@Verony-makesIT Thank you for your pull-request.
I've gone over it and applied some styling.

I thought in the settings there used to be a setting for "Enable Zugferd", did you disable that?
Is your e-invoicing solution just now in plain sight?

E-Invoicing, at least the Ubl, has lots of formats.
Did you count on all those formats?

I see ZugFerd and Ubl, do you know of any others?
I thought there was at least one for Finnish users? Or Spanish?
That deviates from the European formats for Ubl?

Verony-makesIT · 2024-11-01T09:55:48Z

@nielsdrost7
1. The change "refactor: rename tab variable to activeTab" causes errors in the 'application\modules\clients\views\view.php' file because of the change of variable $tab to $activeTab.

2. I have indeed removed the setting "Include zugferd" in the "System settings - Invoices" because it is redundant in this functionality.
This can be reset by replacing the "zugferd code" in the file "partial_settings_invoices.php" from line 152 to 167.
What has become visible from my e-invoicing solution:

In the user data I have changed tax information and added bank information including BIC item. I have also added an invoice contact field here.
For the customer I have also added an invoice contact field and a selection field for the e-invoicing data format for that customer.
In the /libraries folder, the "ZugferdXml.php" has not yet been replaced.
In "application/libraries/XMLtemplates" and "application/helpers/XMLconfigs", the folders and files have been added.

3. Be careful! This is where it gets a bit more complex...
UBL is a global e-invoicing format developed by the OASIS organization. The EU released its EN 16931 guidelines (based on UBL V2.1) in 2017. Only 2 formats (UBL and CII) are allowed here. OpenPEPPOL is the network that ensures the receipt and sending of structured e-invoices worldwide (only UBL or CII). The Peppol BIS V3 format is a subset of the EN16931 format. Within this EN16931, each country can impose specific restrictions and/or extensions, i.e. in a CIUS. There are several countries (e.g. the Netherlands = NLCIUS) that use such a CIUS. This does not mean that this is a different format but only a (limited) adjustment.
In Germany, the CII formats Zugferd and XRechnung are used.
In France, the CII format Factur-X is used which is compatible with the German Zugferd from V 2.1.

In my e-invoicing solution you can add any "format" based on an (xml) template... that the user would like to receive.

nielsdrost7 · 2024-11-01T11:35:35Z

@Verony-makesIT thank you for that explanation.

There are several countries (e.g. the Netherlands = NLCIUS) that use such a CIUS. This does not mean that this is a different format but only a (limited) adjustment.
In Germany, the CII formats Zugferd and XRechnung are used.
In France, the CII format Factur-X is used which is compatible with the German Zugferd from V 2.1.

Maybe obsolete question, but humor me:
Let's say we make a release with this pull-request in it.
And someone wants to end an e-invoice to The Netherlands will he need to adjust the format?
So an extra format in the selectbox, especially for The Netherlands?

Verony-makesIT · 2024-11-06T15:46:55Z

@nielsdrost7:
This is a fair question:
In the Netherlands, as in most EU countries, the EN 16931 (EU-N) standard (UBL V2.1 subset) is applied.
The format/syntax to be sent depends solely on which format "your client" wants to receive!
This means that if someone sends an e-invoice to a client in the Netherlands, that choice (template) must indeed be available in the selection box for that client.
You cannot simply assume that you can/may send a standard EU-N with NL-CIUS format to any client in the Netherlands.

FYI:
The NL-CIUS contains about 12 restrictions and/or extensions.
All the CIUSes in Europe usually only contain a small and limited number of changes to the EU-N.
Belgium does not have a CIUS (deviations) and uses the standard EU-N syntax.
However, if you send all your e-invoices via the PEPPOL network rather than via email, your service provider can take care of the conversion to the correct format.

nielsdrost7 · 2024-11-06T16:22:48Z

@Verony-makesIT thank you for the info. That sounds good man!

However, if you send all your e-invoices via the PEPPOL network rather than via email, your service provider can take care of the conversion to the correct format.

How do we send it through the PEPPOL Network?

Verony-makesIT · 2024-11-07T16:54:04Z

@nielsdrost7:
Simply put via a Peppol service provider over SFTP or API.
Mostly they also want to use their own (UBL or json) format or in the worst case have their own invoicing app... ;-(

nielsdrost7 · 2024-11-08T03:14:03Z

@Verony-makesIT

This means that if someone sends an e-invoice to a client in the Netherlands, that choice (template) must indeed be available in the selection box for that client.

Let's make that NLCIUS template.
If we copy/paste the standard and rename it to the Dutch variation.
I would love to release InvoicePlane including that Dutch CIUS variation.

We probably need to make some documentation anyway, would you like to start on that.

accesslint

There are accessibility issues in these changes.

accesslint · 2024-11-09T13:06:08Z

+                                <!-- ZUGFeRD Template Usage -->
+                                <div class="form-group">
+                                    <label for="settings[use_zugferd]"><?php echo trans('use_zugferd'); ?></label>
+                                    <select name="settings[use_zugferd]" id="use_zugferd" class="form-control">


Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

accesslint · 2024-11-09T13:06:08Z

+                                <!-- Default UBL Template Type -->
+                                <div class="form-group">
+                                    <label for="settings[default_template_type]"><?php echo trans('default_ubl_template_type'); ?></label>
+                                    <select name="settings[default_template_type]" id="default_template_type" class="form-control">


Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

- Added fields in tables ip_users and ip_clients. - Removed zugferd selection in invoices - setting. - Added e-Invoice format selection choice for client - bank info input fields for user added and grouped - placed xml configuration files in the folder helpers/XMLconfig - placed xml-template files (Zugferd + UBL example) in the folder libraries/XMLtemplates - created the readme file "About e-Invoicing templates" = How to add/setup XML-template files

…. Includes Zugferd 1.0

accesslint

There are accessibility issues in these changes.

accesslint · 2024-11-21T14:24:21Z

+                                <!-- ZUGFeRD Template Usage -->
+                                <div class="form-group">
+                                    <label for="settings[use_zugferd]"><?php echo trans('use_zugferd'); ?></label>
+                                    <select name="settings[use_zugferd]" id="use_zugferd" class="form-control">


Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

accesslint · 2024-11-21T14:24:21Z

+                                <!-- Default UBL Template Type -->
+                                <div class="form-group">
+                                    <label for="settings[default_template_type]"><?php echo trans('default_ubl_template_type'); ?></label>
+                                    <select name="settings[default_template_type]" id="default_template_type" class="form-control">


Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

- Added fields in tables ip_users and ip_clients. - Removed zugferd selection in invoices - setting. - Added e-Invoice format selection choice for client - bank info input fields for user added and grouped - placed xml configuration files in the folder helpers/XMLconfig - placed xml-template files (Zugferd + UBL example) in the folder libraries/XMLtemplates - created the readme file "About e-Invoicing templates" = How to add/setup XML-template files

…. Includes Zugferd 1.0

…nvoicePlane/InvoicePlane into feature/939-peppol-zugferd-e-invoicing

…ub.com/InvoicePlane/InvoicePlane into feature/939-peppol-zugferd-e-invoicing

nielsdrost7 marked this pull request as draft October 30, 2024 07:55

nielsdrost7 marked this pull request as ready for review October 31, 2024 07:05

nielsdrost7 requested a review from mheiduk October 31, 2024 07:09

nielsdrost7 marked this pull request as draft October 31, 2024 07:09

nielsdrost7 added this to the 1.6.2 milestone Nov 8, 2024

accesslint Bot reviewed Nov 9, 2024

View reviewed changes

Verony-makesIT and others added 13 commits November 10, 2024 02:52

AccessLint issues updated

f12e54e

Update: Changed datatype Text to Varchar

6974fce

Added validation rules: 'xss_clean' and 'trim'

6fa5e0a

Removed xss_clean. Was not needed here.

5f689be

939: Prep for incoming merge-request

4c04c8c

939: Just style fixes for now

0f72f89

939: Prep for incoming merge-request

dd57b2e

939: Applied formatting and put back the zugferd stuff (just in case)

597aa1b

939: Prep for incoming merge-request

35fdf01

939: Just style fixes for now

175b49b

939: e-invoicing overhaul with a nice (sortof) Enum for Ubl Templates…

c128ee3

…. Includes Zugferd 1.0

nielsdrost7 force-pushed the feature/939-peppol-zugferd-e-invoicing branch from 608d650 to c128ee3 Compare November 10, 2024 10:04

nielsdrost7 marked this pull request as ready for review November 10, 2024 10:05

nielsdrost7 marked this pull request as draft November 10, 2024 10:06

ZUGFeRD 2.3

9d53446

accesslint Bot reviewed Nov 21, 2024

View reviewed changes

nielsdrost7 and others added 25 commits November 21, 2024 07:40

Zugferd improvement

43547d4

AccessLint issues updated

cbf5a2f

Update: Changed datatype Text to Varchar

7078402

Added validation rules: 'xss_clean' and 'trim'

580a833

Removed xss_clean. Was not needed here.

e3d02ae

Clients

04ecde2

939: Just style fixes for now

8e09638

939: Prep for incoming merge-request

f0b156e

939: Applied formatting and put back the zugferd stuff (just in case)

ac3d140

939: Prep for incoming merge-request

cb454b5

ZUGFeRD 2.3

bb9df25

939: Just style fixes for now

3953cd0

939: e-invoicing overhaul with a nice (sortof) Enum for Ubl Templates…

d0fe8ab

…. Includes Zugferd 1.0

939: Code Style fixes and backup texts when stuff is not there

60a1621

ZUGFeRD 2.3

e539528

Zugferd improvement

a9a474d

ZUGFeRD 2.3

9f8b2dc

merged development

1506e67

Merge branch 'feature/939-peppol-zugferd-e-invoicing' of github.com:I…

ed4fbac

…nvoicePlane/InvoicePlane into feature/939-peppol-zugferd-e-invoicing

ZUGFeRD 2.3

b09603f

Merge branch 'feature/939-peppol-zugferd-e-invoicing' of https://gith…

c572cfd

…ub.com/InvoicePlane/InvoicePlane into feature/939-peppol-zugferd-e-invoicing

?

1c19a08

In clean code, variables are initialised.

72f2d3c

nielsdrost7 mentioned this pull request Nov 30, 2024

[IP-999]: ZUGFeRD 2.2 #1048

Closed

7 tasks

nielsdrost7 closed this Jan 18, 2025

nielsdrost7 deleted the feature/939-peppol-zugferd-e-invoicing branch January 18, 2025 14:25

Conversation

nielsdrost7 commented Oct 30, 2024

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Pull Request Checklist

Issue Type (Please check one or more)

Uh oh!

nielsdrost7 commented Oct 30, 2024

Uh oh!

nielsdrost7 commented Oct 31, 2024

Uh oh!

Verony-makesIT commented Nov 1, 2024

Uh oh!

nielsdrost7 commented Nov 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Verony-makesIT commented Nov 6, 2024

Uh oh!

nielsdrost7 commented Nov 6, 2024

Uh oh!

Verony-makesIT commented Nov 7, 2024

Uh oh!

nielsdrost7 commented Nov 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

accesslint Bot left a comment

Choose a reason for hiding this comment

Uh oh!

accesslint Bot Nov 9, 2024

Choose a reason for hiding this comment

Uh oh!

accesslint Bot Nov 9, 2024

Choose a reason for hiding this comment

Uh oh!

accesslint Bot left a comment

Choose a reason for hiding this comment

Uh oh!

accesslint Bot Nov 21, 2024

Choose a reason for hiding this comment

Uh oh!

accesslint Bot Nov 21, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nielsdrost7 commented Nov 1, 2024 •

edited

Loading

nielsdrost7 commented Nov 8, 2024 •

edited

Loading