Rebuild UI #510
Merged
Rebuild UI #510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(AI generated commit message because I made too many changes... again) - Updated `Application.xaml` - Improved `OnStartup` method in `Application.xaml.vb` for better multi-instance handling with mutex and named pipe server. - Modified `ApplicationHostService` for robust window management based on command-line arguments. - Enhanced `CustomSnackBarService` to effectively manage notifications for compression results. - Updated `FolderViewModel` with new properties and commands for folder actions and wiki submissions. - Improved layout and functionality in `MainWindow` and `MainWindow.xaml`. - Redesigned `SettingsView` and `SettingsViewModel` for intuitive settings management. - Introduced new classes: `BackgroundImageChangedMessage`, `SemVersion`, `TrayNotifierService`, `UpdaterService`, and `WikiService` for specific functionalities. - Updated `HomeViewModel` for better folder action management and user notifications. - Redesigned `SettingsPage` for improved usability and layout adjustments.
This reverts commit 451d687.
- Increased idle timer duration in `IdleDetector` from 2 to 5 seconds. - Adjusted `DecayPercentage` calculation in `WatchedFolder` to return 1 when sizes are equal and updated `SavedSpace` calculation. - Enhanced `Watcher` to start `IdleDetector`; modified `UpdateWatched` to include `isFreshlyCompressed` parameter. - Converted `OnSystemIdle` to an asynchronous method with re-entrance checks and logging. - Made `Analyser` a class-level variable in `CompressableFolder`. - Updated `FolderViewModel` to pass an additional parameter to `UpdateWatched` during uncompression. - Changed `HomeViewModel` to call `UpdateWatched` for compressed folder notifications and refactored folder addition to `AddOrUpdateFolderWatcher`.
…ent colour for pre-release updates
… expensive setter operation if it's not needed
- Fixed crash when adding an unsupported folder to the Watcher page
There was a problem hiding this comment.
Pull Request Overview
This PR rewrites the UI layer by replacing ModernWPF with WPFUI, introduces dependency injection hosting, and adds multi‐folder queuing for compression.
- Swapped out ModernWPF components in favor of WPFUI resources and controls
- Integrated Microsoft.Extensions.Hosting and DI for services and view models
- Refactored converters and core types to use new
WOFCompressionAlgorithmenum and updated progress reporting
Reviewed Changes
Copilot reviewed 76 out of 76 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| CompactGUI/Components/Custom/TokenizedTextBox.vb | Updated event handler registration to use base class member |
| CompactGUI/Components/Converters/IValueConverters.vb | Replaced CompressionAlgorithm with WOFCompressionAlgorithm and added new converters |
| CompactGUI/Components/Converters/Converters.xaml | Enabled new converters and commented out unused ones |
| CompactGUI/Application.xaml.vb | Introduced DI host startup and replaced legacy startup logic |
| CompactGUI.Watcher/WatchedFolder.vb | Adjusted decay and saved‐space calculations |
| CompactGUI.Core/SharedObjects.vb | Converted fields to properties and introduced CompressionProgress |
Comments suppressed due to low confidence (2)
CompactGUI/Application.xaml.vb:214
- Event handler signature for IdleDetector.IsIdle expects a Sub(sender, args), not an Async Function with no parameters; update the signature or wrap it in a compatible delegate.
Private Async Function OnSystemIdle() As Task
CompactGUI/Components/Converters/IValueConverters.vb:258
- ColorConverter.ConvertFromString returns an Object, not a Color; you need to cast it (e.g. CType(ColorConverter.ConvertFromString(...), Color)) before passing to SolidColorBrush.
Return New SolidColorBrush(ColorConverter.ConvertFromString("#6E9DEF"))
|
Why not change the banner of the readme to a new version of the interface, it will look better than before 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ModernWPFtoWPFUII'm not exactly happy with the current look of the UI, but it is more functional 🤷