fix(ui/ux): address issues #821, #822, #824, #826 - #1002
Open
maccoder374-sudo wants to merge 1 commit into
Open
Conversation
…-IV#826 - Iris-IV#821: Add visible loading state to CampaignMap with isLoading prop and spinner overlay - Iris-IV#822: Visually distinguish current wallet signer in MultiSigWithdrawalPanel with highlight and 'You' badge - Iris-IV#824: Replace QR modal with inline QR panel co-located in share panel for keyboard/screen-reader accessibility - Iris-IV#826: Make AnimatedProgressFill respect prefers-reduced-motion by rendering final width immediately when reduced motion is preferred Co-authored-by: maccoder374-sudo <maccoder374-sudo@users.noreply.github.com>
|
@maccoder374-sudo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Auto-review failed (API error). Leaving PR for human review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements four UI/UX fixes for the ProofOfHeart-frontend:
Issues Closed
Changes
Issue #821: CampaignMap has no visible loading state while markers load
isLoadingprop toCampaignMap(defaults tofalsefor backward compatibility)isLoadingis true, a spinner overlay with "Loading map…" text is shown over the map containerIssue #822: MultiSigWithdrawalPanel does not show who has and hasn't signed a proposal
Issue #824: ShareButtons and QR code entry points are not co-located
aria-expanded,aria-controls, androle="region"attributes for keyboard and screen-reader accessibilityIssue #826: AnimatedProgressFill ignores prefers-reduced-motion on individual instances
useReducedMotionhook inAnimatedProgressFillprefers-reduced-motionis preferred, the component renders the final width immediately as a plain<div>instead of using Framer Motion spring animationsTesting
All new and existing tests pass.