test: add third-party script error handling and duplicate prevention coverage - #888
Open
JemimahEkong wants to merge 1 commit into
Open
test: add third-party script error handling and duplicate prevention coverage#888JemimahEkong wants to merge 1 commit into
JemimahEkong wants to merge 1 commit into
Conversation
…coverage - Add onError callback to ThirdPartyScript interface - Add dedup-by-id guard in getThirdPartyScripts() - Wire onError prop in ThirdPartyScripts component - Add handleScriptError() helper - Add tests for error event handling and duplicate script IDs
|
@JemimahEkong Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Auto-review failed (API error). Leaving PR for human review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: test(third-party): add script error handling and duplicate prevention coverage
This PR improves third-party script reliability by adding coverage for script load failures and preventing duplicate script injection scenarios.
Problem
The third-party script loading module lacked tests for two important edge cases:
What changed
src/lib/thirdParty.tsAdded optional
onError?: () => voidsupport toThirdPartyScriptso consumers can provide script-specific failure handlers.Added duplicate script protection in
getThirdPartyScripts():idvalues are filtered out.Exported
handleScriptError(script)helper:src/components/ThirdPartyScripts.tsxUpdated script rendering logic to:
onErrorfrom each script configuration.<Script onError={...}>handler.Test coverage
Added 2 new tests in:
src/__tests__/lib/thirdParty.test.tsCovered scenarios:
✅ Script load error handling
onErrorcallbacks are executed throughhandleScriptError.✅ Duplicate script prevention
Validation
✅ All 12 tests passing
✅ No regressions introduced
Closes #844