fix(notifications): abort inflight fetch on unmount (#555) - #893
Open
TCROWN10 wants to merge 1 commit into
Open
Conversation
Use AbortController in useNotifications refresh/cleanup so a remount cannot apply setNotifications from a previous poll (Iris-IV#555). Co-authored-by: Cursor <cursoragent@cursor.com>
|
@TCROWN10 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Auto-review failed (API error). Leaving PR for human review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetchNotificationson unmount/wallet change viaAbortControllerso remounts cannot callsetNotificationsafter cleanupCloses #555
Type of Change
Test plan
npm test -- --runTestsByPath src/__tests__/hooks/useNotifications.test.tsx