Fix #437: Check require_not_paused before pending.require_auth()

[pixels26]

Summary

In src/campaigns/transfer.rs, accept_campaign_transfer was calling require_not_paused after pending.require_auth(), causing users to waste a signature when the contract is paused.

Changes

• Moved require_not_paused(env)? before pending.require_auth() so users are informed the contract is paused before being asked to sign.

Close #437

[drips-wave]

@pixels26 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

[davidmaronio]

nice focused fix. moving require_not_paused ahead of pending.require_auth() in src/campaigns/transfer.rs:59 closes the gap from #437 where a user could be asked to authorize a transfer acceptance on a paused contract, and CI is green.

two small notes:

1. src/campaigns/transfer.rs:56-61 - you check pause after resolving pending_creator, so a paused contract still returns NoTransferPending for campaigns without a pending transfer. fix: move require_not_paused before require_auth in accept_campaign_transfer (#453) #700 puts the pause check right after require_active_campaign, before any pending lookup, which is slightly more consistent with fail-fast ordering. not a blocker, but worth considering while you are in here.

2. the deletions in src/admin.rs, src/campaigns.rs, src/lib.rs and the test_campaign_update.rs event payload fixes look like they duplicate cleanup already merged to main, which is why the branch reads behind. a rebase should shrink this diff to just the transfer.rs change.

heads up that #700 (issue #453) makes the identical reorder in the same function, so whichever lands first will conflict the other; this one is green so it likely goes first. please rebase on main and this can merge.

[pixels26]

@davidmaronio please check now

[davidmaronio]

heads up: #722 just merged and it carried this exact require_not_paused reorder in transfer.rs (same 1-line move), so the #437 fix is on main now. closing this as completed elsewhere, nothing wrong with the change itself. thanks for the fix, sorry the revert pr beat you to it.