fix: guarantee wasm build reproducibility via dockerized make target - #724
Open
bbkenny wants to merge 4 commits into
Open
fix: guarantee wasm build reproducibility via dockerized make target#724bbkenny wants to merge 4 commits into
bbkenny wants to merge 4 commits into
Conversation
Added a Makefile utilizing the official stellar/rs-soroban-sdk docker image to ensure the WASM bytecode generated is deterministic. This resolves the security concern where deployed contracts could not be independently verified against source. Also updated docs, changelog, and removed a stray unlinked file to clear compilation blockers.
|
@bbkenny Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
Author
|
Hey @Iris-IV, apologies for the CI failure! I just pushed a fix to remove some stray, orphaned blocks of code ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #533
Summary of Changes
Added a Dockerized Makefile to guarantee that the compiled WASM binary is deterministic and reproducible. Before this, the build process produced different hashes across different host environments, meaning the on-chain bytecode couldn't be independently verified against the source code.
What changed
Makefilewith abuild-dockertarget that mounts the repository into the officialstellar/rs-soroban-sdk:20.1.0image.README.mdandCONTRIBUTING.mdto split local development builds from the reproducible production builds.src/campaigns.rsfile that was orphaned in the repo and failing compilation.Testing / Local Verification
cargo fmt --checkandcargo clippy --all-targets --features testutils -- -D warnings.cargo test --features testutils.