fix: explicit CEI documentation for claim_refund to close #546 - #726
Open
bbkenny wants to merge 4 commits into
Open
fix: explicit CEI documentation for claim_refund to close #546#726bbkenny wants to merge 4 commits into
bbkenny wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #546
Summary of Changes
Added a comment to
claim_refundinsrc/contributions.rsexplicitly documenting that the token transfer follows the Checks-Effects-Interactions (CEI) pattern.claim_refundwas already safe and implemented the CEI pattern correctly (i.e. updating state by removing contribution records before initiating the transfer), preventing a malicious token contract from double-claiming refunds. This PR serves to explicitly document this to close the lingering security issue.