Ports NTNRC Overhaul From Doppler#794
Draft
Skies-Of-Blue wants to merge 6 commits intoIrisSS13:masterfrom
Draft
Conversation
Contributor
|
posts a few notes with zero understandings of the ramifications or how easy they are to fix :)
|
Contributor
Author
|
Drafted until feedback is addressed |
Contributor
Author
|
Draft maintained for the time being. Should get this finished before end of server lifespan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Verbose descriptions can be found in the original PRs this is porting:
DopplerShift13/DopplerShift#205
DopplerShift13/DopplerShift#371
DopplerShift13/DopplerShift#377
tl;dr: adds the chat client app to all PDAs (and silicons!), creates a general chat + ai request chat at roundstart (the former unmoderated, and the latter moderated by the station AI, neither having passwords by default), and adds a keybind to support easier IRC messaging. See above PRs OR changelog for more granular details.
This is a decently sized PR, and I'm fully willing to atomize this if needed.
Why it's Good for the Game
Ports requested by the server's favorite deaf teshari.

I've seen a few players recently express their discontent with the Radio as a necessity for communication, and several more express an interest in exploring alternate forms of IC interaction. This provides the potential to kill a few birds with one (very large) stone!
Plus, it allows players to express their character's typing style more than just the rare PDA Message sent! It may even have the knock-on effect of making the cargo channel be used...
Proof of Testing
general channel
ai-request channel
Channel spawns roundstart, allowing all players to freely join.
When an AI spawns (either roundstart or latejoin), they are added to the channel and given admin perms.
keybind
Keybind only functions when your PDA is worn, when the PDA is on, and when the ChatClient app is either active or minimized.
Changelog
🆑 00-Steven, Ephemeralis, carpotoxin
add: Every PDA now starts with the NTNRC chat client, including borgs and AIs!
add: The NTNRC chat client has a new common #general channel, which every crewmember gets added to upon joining the station.
add: A new NTNRC username preference has been added to the names menu. Your NTNRC username is automatically set to this value.
qol: Opening the NTNRC chat client will auto-open the common channel, if you haven't left it.
qol: NTNRC messages from your active chat channel now show up in the chat window if your PDA is active and on your person.
add: The IRC keybind has been added (defaults to Shift-;), which lets you send a message to your active NTNRC channel quickly so long as your PDA is in your hands, on your belt, or in your ID slot. This also works for silicons without those restrictions.
add: The station AI gets their own NTNRC chat-room to moderate.
/:cl: