Adds 2 quirks, hides some quirks from med records, fixes negative knockback#874
Open
BNGP0 wants to merge 4 commits intoIrisSS13:masterfrom
Open
Adds 2 quirks, hides some quirks from med records, fixes negative knockback#874BNGP0 wants to merge 4 commits intoIrisSS13:masterfrom
BNGP0 wants to merge 4 commits intoIrisSS13:masterfrom
Conversation
- Makes it so negative knockback doesn't reset to positive every time it's used - Adds a variable that allows you to hide quirks from medical records so they're not omnipresent anymore. Why would medbay find out about your black market connections or magic skills while security couldn't? - adds a "no soul" quirk - adds a "no mirror reflection" quirk
prodirus
reviewed
Feb 23, 2026
| /datum/quirk/no_reflection | ||
| name = "No mirror reflection" | ||
| desc = "You do not reflect in mirrors." | ||
| icon = FA_ICON_EGG //the egg looks similar enough to a mirror. change this if needed |
Contributor
There was a problem hiding this comment.
Gonna need a different icon, it's already used by bald.
prodirus
reviewed
Feb 23, 2026
Contributor
|
Ideally the quirk changes, new quirks and knockback fix would each be atomised into their own PRs/branches, but eh.... |
prodirus
reviewed
Feb 23, 2026
prodirus
reviewed
Feb 23, 2026
| if(throw_distance < 0) | ||
| throw_dir = REVERSE_DIR(throw_dir) | ||
| throw_distance *= -1 | ||
| TD = throw_distance * -1 |
Contributor
There was a problem hiding this comment.
I'd generally avoid using capitals in varnames, especially allcaps as that's used for defines, but it's not the hugest deal just a personal nitpick.
changes reflectionless icon so it no longer conflicts with the bald
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Adds 2 quirks: Soulless and No mirror reflection, both give you traits that already existed. Adds a variable that allows you to make some quirks from med records (it probably should be toggleable for each quirk on a character but i don't know TGUI well enough to implement that). Negative knockback now no longer resets every time it's used. i think it still might ocasionally reset if you're using multiple projectile spells with knockback element, but it that happens way less frequently.
Why it's Good for the Game
If you sell your soul in one round you can actually make it canon by selecting the soulless quirk. Hemophages can get even more vampire flavor and have no mirror reflection. Finally adds a way to hide quirks from the all-knowing medical records that for some reason have to know about every single medicine unrelated trait a character has. You can now actually give weapons and spells negative knockback (through admin tools) and it won't reset to positive after the first hit.
Proof of Testing
Changelog
🆑
add: Added soulless quirk
add: Added no mirror reflection quirk
balance: made underworld connections and magical skills quirks hidden from the medical records.
code: added a variable that hides quirks from medical records
fix: Negative knockback no longer resets to positive on every use
/:cl: