Consume updated uniffi #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which we opt out of since we don't need to allow for foreign implementation of our clients
Uniffi folks are open to eigerco docstring behavior I'd implemented that does this for us when the docstring hasn't been overridden, but it isn't in yet.
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against f89d443 |
coltfred
approved these changes
Jan 5, 2024
cjyar
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses their new docstring generation and opts-out of the now opt-in callback interfaces that would make our traits implementable by foreign consumers (because it doesn't work with
ByRefargs right now.Depends on a PR branch that's slated for release in 0.26.
Their docstring implementation doesn't copy trait method docstrings onto impl-d methods when not overridden like I'd made it do in the branch we were using. For now I've copied all the relevant comments around, but we could PR having uniffi do it in the future.