fix: support ssl, no need to initial ssl lib when use. #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IronsDu
reviewed
Aug 21, 2020
| @@ -93,6 +93,10 @@ namespace brynet { namespace net { | |||
| { | |||
| return false; | |||
| } | |||
| SSL_library_init(); | |||
There was a problem hiding this comment.
这里加上的话，用户构建SSL服务的话，省以下调用，没问题。
另外，客户端的SSL，仍然需要用户自己手动调用。 目前没找到怎么去帮助客户端调用。（如果这些调用不太耗时的话，倒是可以放在 https://github.com/IronsDu/brynet/blob/master/include/brynet/net/TcpConnection.hpp#L354 里。）
另外，我还不太确认这几个函数是否线程安全和是否可重复调用。
| @@ -6,6 +6,7 @@ | |||
| #include <brynet/net/TcpService.hpp> | |||
| #include <brynet/net/wrapper/ServiceBuilder.hpp> | |||
| #include <brynet/base/AppStatus.hpp> | |||
| //#define USE_SSL | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
作为独立的模块，外面使用时最好感知不到ssl相关api。(不知这样设计，是否是因为怕多个模块都引用ssl导致多次初始化？)