Skip to content

fix: Fix text overlap with tab bar on iOS by using device viewport height (100dvh) #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nangazaki wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Fix text overlap with tab bar on iOS by using device viewport height (100dvh) #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ccc9b2
fix: Fix text overlap with tab bar on iOS by using device viewport he…
nangazaki Feb 14, 2025
7022844
Merge branch 'main' into fix-text-overlaps-on-ios
nangazaki Feb 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ function App() {
};

return (
<div className="h-screen w-full bg-black text-white overflow-y-scroll snap-y snap-mandatory hide-scroll">
<div className="h-dvh w-full bg-black text-white overflow-y-scroll snap-y snap-mandatory hide-scroll">
<div className="fixed top-4 left-4 z-50">
<button
onClick={() => window.location.reload()}
Expand Down Expand Up @@ -246,7 +246,7 @@ function App() {
))}
<div ref={observerTarget} className="h-10 -mt-1" />
{loading && (
<div className="h-screen w-full flex items-center justify-center gap-2">
<div className="h-dvh w-full flex items-center justify-center gap-2">
<Loader2 className="h-6 w-6 animate-spin" />
<span>Loading...</span>
</div>
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/components/WikiCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export function WikiCard({ article }: WikiCardProps) {
};

return (
<div className="h-screen w-full flex items-center justify-center snap-start relative" onDoubleClick={() => toggleLike(article)}>
<div className="h-dvh w-full flex items-center justify-center snap-start relative" onDoubleClick={() => toggleLike(article)}>
<div className="h-full w-full relative">
{article.thumbnail ? (
<div className="absolute inset-0">
Expand All @@ -72,7 +72,7 @@ export function WikiCard({ article }: WikiCardProps) {
<div className="absolute inset-0 bg-gray-900" />
)}
{/* Content container with z-index to ensure it's above the image */}
<div className="absolute backdrop-blur-xs bg-black/30 bottom-[10vh] left-0 right-0 p-6 text-white z-10">
<div className="absolute backdrop-blur-xs bg-black/30 bottom-[4dvh] left-0 right-0 p-6 text-white z-10 md:bottom-[10dvh]">
<div className="flex justify-between items-start mb-3">
<a
href={article.url}
Expand Down