Changing Display Contexts to Block Visibility #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
all blocks that were relying on the 'collection' context are now configured under block groups and those block groups are configured with block visibility equivalent to the 'collection' context.
…tarter-site into hackdoc-display-contexts-to-block-visibility
JojoVes
changed the title
rosiel
reviewed
Jul 18, 2025
Contributor
|
@JojoVes good stuff! can you rework this to use the new release with your code change to islandora, https://github.com/Islandora/islandora/releases/tag/2.16.3 ? |
|
This PR is being marked as stale from inactivity and will be automatically closed in 90 days unless further action is taken. If this PR is still relevant please comment. Please also consider attending the weekly Tech Call to discuss the PR |
|
Still relevant. |
Contributor
|
ping @JojoVes it'd be nice to have this in. Can you get to it? or I can do the patch-ectomy referenced in my earlier comment if you don't have time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires changes from Islandora/islandora#1084 (currently applied as a patch)
To facilitate block config organization, this is installing and enabling Block Group module as well as moving all Context logic for block placement to be in block visibility instead.
I'm not sure if it would be too heavy-handed to fully remove all the Display Contexts here, so I've opted just to disable them, though I think it would be cleaner to remove them completely.