Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove recast #346

Merged
merged 1 commit into from
Sep 13, 2023
Merged

remove recast #346

merged 1 commit into from
Sep 13, 2023

Conversation

joecorall
Copy link
Contributor

@joecorall joecorall commented Jun 16, 2023

Closes #299

make starter TAG=2.0.0 is failing with

Error response from daemon: manifest for islandora/recast:2.0.0 not found: manifest unknown: manifest unknown

See Islandora-Devops/isle-buildkit#220 for additional discussion around removing recast. It was removed from isle-buildkit with Islandora-Devops/isle-buildkit#238

With this PR make starter TAG=2.0.0 builds OK.

@DonRichards
Copy link
Member

I'm getting the following error with this PR.

make starter-finalize ENVIRONMENT=starter
make[1]: Entering directory '/Users/admin/isle-dc'
docker compose exec -T drupal with-contenv bash -lc 'chown -R nginx:nginx .'
make drupal-database update-settings-php
make[2]: Entering directory '/Users/admin/isle-dc'
make[2]: Leaving directory '/Users/admin/isle-dc'
make[2]: *** [Makefile:528: drupal-database] Error 143
make[1]: *** [Makefile:577: starter-finalize] Error 2
make[1]: Leaving directory '/Users/admin/isle-dc'
make: *** [Makefile:173: starter] Error 2

@joecorall
Copy link
Contributor Author

joecorall commented Sep 8, 2023

@DonRichards that's fixed with #347

That issue is related to the version of PHP running in the drupal container, and not an issue with removing recast.

@DonRichards
Copy link
Member

Brought this up in the tech call. And since this works with make local we came to the conclusion this works and can be merged.

@DonRichards DonRichards merged commit 7ef18bb into Islandora-Devops:development Sep 13, 2023
@joecorall joecorall deleted the rm-recast branch September 13, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Recast
2 participants