-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix make starter and add nightly build check #384
Conversation
@joecorall Thank you for doing this! Edit note: I removed my original question here that was asking about an error with generate secrets on Windows because it was unrelated to the Windows test issue. I removed this for clarity in case anyone reads this in the future while trying to troubleshoot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is all solid, and make starter
works again,
Resolves #380 #357
Also tested
make starter_dev
on this PR and it successfully builds so think this also resolves #354Before
Fails with
After
Successfully builds
Tests
Also added a test on pushes to this repo to ensure
make starter build production
work. Added a nightly build to also perform the check and send failure notifications to#bots
in Islandora Slack