Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated layout of docker installation pages in preparation for site template docs #2306

Merged
merged 3 commits into from
May 30, 2024

Conversation

joshdentremont
Copy link
Contributor

@joshdentremont joshdentremont commented May 21, 2024

Purpose / why

Preparation for more docs on the site template. This is the first step to addressing #2302

What changes were made?

Updated docker installation page layout to group isle-dc and site template under "Docker" and added more folders to keep the docs separate. Also a couple small wording changes so that prereqs and intro to isle can be shared between both.

Verification

Check that the pages still load.

Interested Parties

@Islandora/documentation

Checklist

Pull-request Reviewer

Pull-request reviewer should ensure the following:

Person Merging

The person merging should ensure the following:

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

Copy link
Member

@rosiel rosiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've put a PR on your repo to add redirects and fix a broken link I found.
Other than that looks good! Approving.

@joshdentremont
Copy link
Contributor Author

Thanks @rosiel that has been merged now

@rosiel rosiel merged commit 5a8d5ac into Islandora:main May 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants