ISLANDORA-2248: Prevent PHP Strict standards issue #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: https://jira.duraspace.org/browse/ISLANDORA-2248
What does this Pull Request do?
Avoid
in PHP 5.4+ (note that this error has been observed also in TravisCI's build step).
What's new?
Update signature of
_XMLDocument::loadHTMLFile()
to account for optional$options
argument introduced in PHP 5.4 (see JIRA ticket for more background).How should this be tested?
Execute
inside the PHP Lib module directory (
/var/www/drupal/sites/all/modules/php_lib
on standard vagrant VM). Before this PR, you would see the aforementioned error, after this PR, you should seeAlternatively, check that this PR passes TravisCI (check logs!).
Additional Notes:
Interested parties
@DiegoPino @Islandora/7-x-1-x-committers