Fix stale/incorrect pillow_jxl/__init__.pyi type stubs - #162
Open
nikosavola wants to merge 1 commit into
Open
Conversation
The stub file no longer matched the compiled Rust extension: Encoder's constructor still listed removed parameters (parallel, has_alpha) and was missing decoding_speed/effort/use_container/use_original_profile, Encoder.__call__ was missing exif/jumb/xmp/compress, Decoder.__call__ claimed a 3-tuple return instead of the real 5-tuple, and JxlBox had no stub at all. Also fixed docstrings that were dangling string literals placed after the function body instead of the first statement in it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stub file no longer matched the compiled Rust extension. Encoder's constructor still listed removed parameters (
parallel,has_alpha) and was missing decoding_speed/effort/use_container/use_original_profile.Encoder.__call__was missing exif/jumb/xmp/compress,Decoder.__call__claimed a 3-tuple return instead of the real 5-tuple, andJxlBoxhad no stub at all.Also fixed docstrings that were dangling string literals placed after the function body instead of the first statement in it.