Add Rust unit tests and fix cargo test/build linking, wire into CI - #163
Open
nikosavola wants to merge 1 commit into
Open
Add Rust unit tests and fix cargo test/build linking, wire into CI#163nikosavola wants to merge 1 commit into
nikosavola wants to merge 1 commit into
Conversation
nikosavola
commented
Aug 28, 2026
nikosavola
commented
- Stop force-enabling pyo3's extension-module feature in Cargo.toml, since that prevents cargo test/cargo build from linking a real test binary (no libpython). This blocked Rust unit tests from ever running in this crate.
- Add #[cfg(test)] coverage for extract_boxes (the hand-rolled JXL container box parser, which processes untrusted file bytes) and for ImageInfo::mode/PixelType::color_encoding/has_alpha, none of which had any prior test coverage. Includes edge cases: truncated 64-bit box headers, empty-payload boxes, and every ImageInfo::mode branch.
- Add a test-rust job to the existing test.yml workflow.
nikosavola
force-pushed
the
rust-tests-ci
branch
from
August 28, 2026 08:37
61148b1 to
bca289e
Compare
- Stop force-enabling pyo3's extension-module feature in Cargo.toml, since that prevents cargo test/cargo build from linking a real test binary (no libpython). This blocked Rust unit tests from ever running in this crate. - Add #[cfg(test)] coverage for extract_boxes (the hand-rolled JXL container box parser, which processes untrusted file bytes) and for ImageInfo::mode/PixelType::color_encoding/has_alpha, none of which had any prior test coverage. Includes edge cases: truncated 64-bit box headers, empty-payload boxes, and every ImageInfo::mode branch. - Add a test-rust job to the existing test.yml workflow.
nikosavola
force-pushed
the
rust-tests-ci
branch
from
August 28, 2026 08:43
bca289e to
0b937fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.