[MOB - 8993] - JWT part 2 with improvements #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Call onTokenRegistrationFailed in more circumstances and rename it 2. Provide an AuthFailure object to onTokenRegistrationFailed
This will make sure that the stale JWT is not being reused again and rather null is passed in JWT field which is recently passed by handler. Basically not treating null differently in failure scenario
Refactor check for shouldIgnoreRetryPolicy logic.
JWT Improvement Part 2
[MOB - 8974] - Adding Bug fixes
evantk91
reviewed
Jul 1, 2024
iterableapi/src/main/java/com/iterable/iterableapi/AuthFailure.java
Outdated
Show resolved
Hide resolved
iterableapi/src/main/java/com/iterable/iterableapi/IterableAuthManager.java
Show resolved
Hide resolved
iterableapi/src/main/java/com/iterable/iterableapi/IterableAuthManager.java
Outdated
Show resolved
Hide resolved
iterableapi/src/main/java/com/iterable/iterableapi/IterableRequestTask.java
Show resolved
Hide resolved
Ayyanchira
force-pushed
the
feature/JWTImprovement
branch
from
77fe31b
to
dc17e42
Compare
evantk91
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃敼 Jira Ticket(s) if any
鉁忥笍 Description