fix: use playable YouTube embeds in video lightbox#1049
Open
stablegenius49 wants to merge 1 commit intoItzCrazyKns:masterfrom
Open
fix: use playable YouTube embeds in video lightbox#1049stablegenius49 wants to merge 1 commit intoItzCrazyKns:masterfrom
stablegenius49 wants to merge 1 commit intoItzCrazyKns:masterfrom
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
youtube-nocookie.comvideo embeds towww.youtube.combefore rendering the lightbox iframeenablejsapi=1attached viaURLSearchParams, with a fallback for malformed URLsTesting
./node_modules/.bin/eslint src/components/SearchVideos.tsx./node_modules/.bin/tsc --noEmitCloses #799.
Summary by cubic
Ensure lightbox YouTube embeds are playable by normalizing
youtube-nocookie.comURLs towww.youtube.comand always addingenablejsapi=1. Fixes #799 where some videos failed to load in the lightbox.youtube-nocookie.comtowww.youtube.combefore rendering the iframe.enablejsapi=1viaURLSearchParams, with a fallback for malformed URLs.Written for commit 8e19f2f. Summary will update on new commits.