fix: cap search writer context before final answer generation#1053
Open
stablegenius49 wants to merge 1 commit intoItzCrazyKns:masterfrom
Open
fix: cap search writer context before final answer generation#1053stablegenius49 wants to merge 1 commit intoItzCrazyKns:masterfrom
stablegenius49 wants to merge 1 commit intoItzCrazyKns:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/lib/agents/search/context.ts">
<violation number="1" location="src/lib/agents/search/context.ts:48">
P2: Unescaped search result content is inserted into `<result>` blocks, so injected `</result>` or `<result>` text can break prompt boundaries and corrupt citations.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| content = `${truncateTextByTokens(fullContent, noteBudget)}${TRUNCATION_NOTE}`; | ||
| } | ||
|
|
||
| const entry = `${prefix}${content}${suffix}`; |
Contributor
There was a problem hiding this comment.
P2: Unescaped search result content is inserted into <result> blocks, so injected </result> or <result> text can break prompt boundaries and corrupt citations.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/lib/agents/search/context.ts, line 48:
<comment>Unescaped search result content is inserted into `<result>` blocks, so injected `</result>` or `<result>` text can break prompt boundaries and corrupt citations.</comment>
<file context>
@@ -0,0 +1,60 @@
+ content = `${truncateTextByTokens(fullContent, noteBudget)}${TRUNCATION_NOTE}`;
+ }
+
+ const entry = `${prefix}${content}${suffix}`;
+ const entryTokens = getTokenCount(entry);
+
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Fixes #1011
Summary by cubic
Caps search-result context passed to the final writer to prevent model context window overflow. Truncates long results with a brief note and applies the cap to both chat and API search flows.
buildSearchResultsContextwith a 20k-token total budget and 2.5k per-result cap.truncateTextByTokens; exportgetTokenCount.SearchAgentandAPISearchAgent.Written for commit 0d09a9a. Summary will update on new commits.