Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Fix issue 2633 - Migrate :screen-transactions to ComposeViewModel and our new architecture #2721

Merged
merged 27 commits into from
Sep 29, 2023
Merged

Fix issue 2633 - Migrate :screen-transactions to ComposeViewModel and our new architecture #2721

merged 27 commits into from
Sep 29, 2023

Conversation

nicolegeorgieva
Copy link
Contributor

@nicolegeorgieva nicolegeorgieva commented Sep 28, 2023 •
edited
Loading

Pull Request (PR) Checklist

Please check if your pull request fulfills the following requirements:

  • The PR is submitted to the main branch.
  • I've read the Contribution Guidelines.
  • I've read the Architecture Guidelines.
  • My code builds and is tested on a real Android device.
  • I confirm that I've run the code locally and everything works as expected.

What's changed?

  • :screen-transactions now uses ComposeViewModel and our new architecture with State and Event
  • Fix bug with category deletion and change texts of the modal to correspond with category
  • Reduce steps of confirm deletion. They're now 2 instead of 3

Does this PR closes any GitHub Issues?

@ILIYANGERMANOV ILIYANGERMANOV merged commit c0fb7ba into Ivy-Apps:main Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ILIYANGERMANOV ILIYANGERMANOV ILIYANGERMANOV left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate :screen-transactions to ComposeViewModel and our new architecture
2 participants
@nicolegeorgieva @ILIYANGERMANOV