Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Balance After Planned Payments #2820

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Balance After Planned Payments #2820

merged 1 commit into from
Nov 16, 2023

Conversation

CedricLindigkeit
Copy link
Contributor

Pull Request (PR) Checklist

Please check if your pull request fulfills the following requirements:

  • The PR is submitted to the main branch.
  • I've read the Contribution Guidelines and my PR doesn't break the "Contributing Rules".
  • I've read the Architecture Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • 🎬 I've attached a screen recoding of the changes.

Tip: drag & drop the video to the PR description.

Screenrecorder-2023-11-16-13-38-45-687.mp4

What's changed?

Describe with a few bullets what's new:

  • Future expenses and the new budget can now be viewed in the balance overview when the month is changed.
  • Income is also correctly taken into account

💡 Tip: Please, attach screenshots and screen recordings. It helps a lot!

Risk Factors

What may go wrong if we merge your PR?

  • Can't think of any risk factors in this case

In what cases your code won't work?

  • Haven't found one so far

Does this PR closes any GitHub Issues?

Check Ivy Wallet Issues.

Replace ISSUE_NUMBER with your issue number (for example Closes #1234). If you've done that correctly, you'll see the issue title linked when previewing your PR description.

Troubleshooting CI failures

If you see any of the PR checks failing (❌) go to Actions and find it there. Or simply click "Details" next to the failed check and explore the logs to see why it has failed.

Detekt

Detekt is a static code analyzer for Kotlin that we use to enforce code readibility and good practices.

To run Detekt locally:

./gradlew detekt

If the Detekt errors are caused by a legacy code, you can suppress them using a basline.

Detekt baseline (not recommended)

./scripts/detektBaseline.sh

Lint

We use the standard Android Lint plus Slack's compose-lints as an addition to enforce proper Compose usage.

To run Lint locally:

./scripts/lint.sh

If the Lint errors are caused by a legacy code, you can suppress them using a basline.

Lint baseline (not recommended)

./scripts/lintBaseline.sh

Unit tests

If this job is failing this means that your changes break an existing unit test. You must identify the failing tests and fix your code.

To run the Unit tests locally:

./gradlew testDebugUnitTest

@CedricLindigkeit CedricLindigkeit changed the title First implementation for forecasting planned payments Balance After Planned Payments #2812 Nov 16, 2023
@CedricLindigkeit CedricLindigkeit changed the title Balance After Planned Payments #2812 Balance After Planned Payments Nov 16, 2023
Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 💯

@ILIYANGERMANOV ILIYANGERMANOV merged commit 0d693c9 into Ivy-Apps:main Nov 16, 2023
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Balance After Planned Payments Example issue
2 participants