Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Fix #3432 Recurring expenses spawn at UTC timing instead of local time #3570

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

Mushfiq1060
Copy link
Contributor

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read and understand the Developer Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
  • 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

Screen recording of your changes (if applicable):

No

What's changed?

Assume that on September 29, 2024, we create a recurring expense named MyRecurrentExpense. Consequently, an entry for MyRecurrentExpense appears in the upcoming section of the home screen for September 29. Previously, this entry was moved to the overdue section at 12:00 AM UTC rather than 12:00 AM local time. Now, the entry is moved to the overdue section at 12:00 AM local time.

N.B: Expenses from September 29 will move to the overdue section on September 30 at 12:00 AM local time.

Risk factors

What may go wrong if we merge your PR?
No

In what cases won't your code work?
No

Does this PR close any GitHub issues? (do not delete)

  • Closes N/A

@ILIYANGERMANOV
Copy link
Collaborator

ILIYANGERMANOV commented Sep 29, 2024

@Mushfiq1060 add screen recording to prove that it works

@ILIYANGERMANOV ILIYANGERMANOV added the requested changes Changes are needed. Please, apply them label Sep 29, 2024
@Mushfiq1060
Copy link
Contributor Author

ok

@Mushfiq1060
Copy link
Contributor Author

@ILIYANGERMANOV screen recording

ivy_recording.mp4

@ILIYANGERMANOV ILIYANGERMANOV added ready to merge 🚀 PR can be merged after the CI pass and removed requested changes Changes are needed. Please, apply them labels Sep 29, 2024
@ILIYANGERMANOV ILIYANGERMANOV merged commit da86ec6 into Ivy-Apps:main Sep 30, 2024
9 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready to merge 🚀 PR can be merged after the CI pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants