-
Notifications
You must be signed in to change notification settings - Fork 724
Refactor TransactionCard UI to support compactMode #3623
Conversation
🚧 WIP |
Hi @ILIYANGERMANOV, how do I take care of the failing screenshot test here? Here is the snapshot of what it expects. Here, in the empty upcoming transaction card, there is the "deleted" tag that is shown however in my implementation of the compact mode I have omitted tags. compactmode_transaction_card_current_state.mp4Can you help me out so I can proceed? Thanks! |
7a0662a
to
94f0fb9
Compare
@ILIYANGERMANOV |
Hey @p42rthicle sorry I missed this PR because the CI was failing and it seemed dangerous to me |
Yes, I think it's some lint checks that are failing. How do I work on it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your compact mode isn't showing accounts and categories. Accounts and categories are essential data. Instead of showing one big INCOME/EXPENSE icon let's display the other useful info. Also how does it work for transfers?
I purposely omitted the categories and accounts info as I wanted the compact mode to display just bare minimum information. However, if you suggest I can add those in the compact mode. |
Pull request (PR) checklist
Please check if your pull request fulfills the following requirements:
Screen recording of your changes (if applicable):
transaction-card-compact.mp4
What's changed?
Describe with a few bullets what's new:
TypeAmountCurrency
in the non-compact card is also nowTitleTypeAmountCurrencyRow
just without showing the titlepaidFor
and is ofINCOME
typeRisk factors
What may go wrong if we merge your PR?
compactModeEnabled
was set totrue
income_received
needs to be edited for the two languages (Have added Todo comments)In what cases won't your code work?
Bool Feature
Does this PR close any GitHub issues? (do not delete)
Troubleshooting GitHub Actions (CI) failures ❌
Pull request checks failing? Read our CI Troubleshooting guide.