Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Add missing spanish labels and descriptions at settings screen #3655

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

Mj-br
Copy link
Contributor

@Mj-br Mj-br commented Oct 31, 2024

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read and understand the Developer Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
  • 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

Screen recording of your changes (if applicable):

  • Please take a look to the screenshots at "Before|After" section.

What's changed?

Describe with a few bullets what's new:

  • I've added the missing translations to Spanish of some labels and descriptions at the Settings screen.

Before|After

Before

Bug screen 1

Bug screen 2

Bug screen 3

Bug screen 4

After

Fix screen 1

Fix screen 2

Fix screen 3

Fix screen 4

Risk factors

What may go wrong if we merge your PR?

  • Nothing

In what cases won't your code work?

  • It won't work if the switchLanguage() function from the SettingsViewModel is deleted.

Does this PR close any GitHub issues? (do not delete)

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

@Mj-br Mj-br requested a review from ILIYANGERMANOV as a code owner October 31, 2024 20:02
@ILIYANGERMANOV ILIYANGERMANOV merged commit 4211084 into Ivy-Apps:main Nov 1, 2024
9 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Some Spanish translations are missing at Setting screen
2 participants