converter for COWVR for the NASA STPH8 mission ocean surface wind product #1647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nternal/ioda-converters into feature/cowvr_osw4ingest
Collaborator
|
The test passed. Shall the |
fcvdb
approved these changes
Jul 18, 2025
haydenlj
approved these changes
Jul 22, 2025
Contributor
haydenlj
left a comment
haydenlj
left a comment
There was a problem hiding this comment.
Thanks @BenjaminRuston !
fabiolrdiniz
requested changes
Aug 14, 2025
Contributor
fabiolrdiniz
left a comment
fabiolrdiniz
left a comment
There was a problem hiding this comment.
Thanks, @BenjaminRuston!
| # use approximate offset of 725846427s between 01Jan1970 and 01Jan1993 | ||
| # missing value assumed minimum (e.g. -9999.0) | ||
| time_offset = obs_time_tai93[:].flatten() | ||
| missing_value = np.min(time_offset) |
Contributor
There was a problem hiding this comment.
A unit test would be helpful, especially in understanding the use of missing_value = np.min(.). Isn't the missing value encoded in the attributes of the file?
| # standard angle conventions (0 degrees at East, increasing counter-clockwise) | ||
|
|
||
| # use minimum as missing value | ||
| missing_value = np.min(windSpeed) |
| windNorthwardError = np.full_like(windSpeed, missing_value, dtype=np.float64) | ||
|
|
||
| # Convert valid wind directions to radians (meteorological to standard) | ||
| rad = np.deg2rad(windDirection[valid_mask]) |
Contributor
There was a problem hiding this comment.
I hope the obs file will indicate the convention being used for the direction (0 degrees = North or East) and "wind blowing from".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The data from COWVR as part of the NASA STPH8 mission has an ocean surface wind product
DOI: 10.5067/COWVR-STPH8-EDR100
from NASA earthdata link early 2025:
https://cmr.earthdata.nasa.gov/virtual-directory/collections/C3237678855-POCLOUD
let's move forward as ingest suite can proceed
a unit test is still required!
To test this converter with Skylab ingest suite please use these dependent branches:
https://github.com/JCSDA-internal/skylab/pull/721
https://github.com/JCSDA-internal/ewok/pull/1136
Issue(s) addressed
Resolves #1646
Dependencies
uses the python bindings to IODA
Impact
provide a converter for NASA data files to IODA
Checklist