-
Notifications
You must be signed in to change notification settings - Fork 14
Add converter for extinction coefficient from CALIOP level 2 aerosol profile (APro) data #1674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
The JEDI integration test is failed with following message. |
…erters' into feature/caliop_converters
…erters' into feature/caliop_converters
|
Thank you, @CoryMartin-NOAA. I will update the code to address your comments. |
Add jedi-ci action Parent issue: JCSDA-internal/jedi-ci#16 Admin merge justification: JCSDA-internal/jedi-ci#17
mer-a-o
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. I see a small change in modis_aod.hdf. Is it because of the change in .gitattributes?
|
@mer-a-o |
|
Looks good, do you have an associated PR that tests this in UFO? |
|
@jeromebarre Yes, https://github.com/JCSDA-internal/ufo/pull/3825. But it is in draft PR, because I am looking into whether there is a better approach to load GeoVals for each profile in Load_Atm and Load_Sfc. |
|
I would refrain on merging this before there is a more matured version of the UFO operator. I have my reservations with using I will add this comment in the UFO PR too. |
jeromebarre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my comment above
Description
This PR adds the converter to process the extinction coefficient from CALIOP Level 2 aerosol profile (APro) data to IODA format.
New variables were introduced.
Issue(s) addressed
Resolves #1711
Dependencies
List the other PRs that this PR is dependent on:
Impact
Expected impact on downstream repositories:
Checklist