Skip to content

Conversation

@weiwilliam
Copy link
Contributor

@weiwilliam weiwilliam commented Jul 16, 2025

Description

This PR adds the converter to process the extinction coefficient from CALIOP Level 2 aerosol profile (APro) data to IODA format.
New variables were introduced.

  • extinctionCoefficient
  • cloudAerosolDiscrimination

Issue(s) addressed

Resolves #1711

Dependencies

List the other PRs that this PR is dependent on:

  • ...

Impact

Expected impact on downstream repositories:

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

@weiwilliam
Copy link
Contributor Author

The JEDI integration test is failed with following message.

icpx: error #10105: gcc: core dumped
icpx: warning #10102: unknown signal(-995144544)
icpx: error #10106: Fatal error in gcc, terminated by unknown
clang++: error: unable to make temporary file: No space left on device
clang++: error: no input files
make[2]: *** [ufo/src/ufo/CMakeFiles/ufo.dir/build.make:7411: ufo/src/ufo/CMakeFiles/ufo.dir/operators/marine/insitutemperature/ObsInsituTemperatureTLAD.cc.o] Error 1
make[2]: *** Waiting for unfinished jobs....
fatal error: error in backend: IO failure on output stream: No space left on device
PLEASE append the compiler options "-save-temps -v", rebuild the application to get the full command which is failing and submit a bug report to https://software.intel.com/en-us/support/priority-support which includes the failing command, input files for the command and the crash backtrace (if any).

@weiwilliam weiwilliam added COMPO Atmospheric COMPOsition do not merge Something is wrong, do not merge labels Jul 31, 2025
@weiwilliam weiwilliam added needs review Asking others to review - often used for pull requests and removed do not merge Something is wrong, do not merge labels Aug 11, 2025
@weiwilliam
Copy link
Contributor Author

Thank you, @CoryMartin-NOAA. I will update the code to address your comments.

@ytremolet ytremolet added the NWS NOAA National Weather Service label Sep 29, 2025
Copy link

@mer-a-o mer-a-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. I see a small change in modis_aod.hdf. Is it because of the change in .gitattributes?

@weiwilliam
Copy link
Contributor Author

weiwilliam commented Oct 15, 2025

@mer-a-o Yes, it should go to LFS. It seems weird now. I will double-check it. Confirmed, this branch stores it in LFS.

@jeromebarre
Copy link

Looks good, do you have an associated PR that tests this in UFO?

@weiwilliam
Copy link
Contributor Author

@jeromebarre Yes, https://github.com/JCSDA-internal/ufo/pull/3825. But it is in draft PR, because I am looking into whether there is a better approach to load GeoVals for each profile in Load_Atm and Load_Sfc.

@jeromebarre
Copy link

jeromebarre commented Oct 16, 2025

I would refrain on merging this before there is a more matured version of the UFO operator. I have my reservations with using atmosphereLayerThicknessZ. I think a top and bottom obs layer pressure should be defined in the ioda file then used in UFO and calculating a more mathematically correct integration on the vertical. Right now the approximaiton that has been coded in in UFO will be innacurate in the case of multiple model levels within an obs layer...

I will add this comment in the UFO PR too.

Copy link

@jeromebarre jeromebarre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comment above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

COMPO Atmospheric COMPOsition needs review Asking others to review - often used for pull requests NWS NOAA National Weather Service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New IODA converter to process extinction coefficient from CALIOP level 2 APro product

7 participants