Skip to content

ahi obs2ioda remove dimension nstring #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenjaminRuston merged 15 commits into from
Nov 10, 2025
Merged

ahi obs2ioda remove dimension nstring #1718

Changes from 7 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ee4f9ea
put definition of nstring in conditional
BenjaminRuston Oct 16, 2025
268784b
remove min_datetime and max_datetime which are undefined
BenjaminRuston Oct 16, 2025
7837354
remove nstring as attribute
BenjaminRuston Oct 16, 2025
9df16df
Merge branch 'develop' into feature/ahi_remove_nstring
BenjaminRuston Oct 21, 2025
b827acc
Merge branch 'develop' into feature/ahi_remove_nstring
BenjaminRuston Oct 23, 2025
9811140
remove writing of nstring dimension and min max time attributes
BenjaminRuston Oct 27, 2025
c492e1d
Merge branch 'develop' into feature/ahi_remove_nstring
BenjaminRuston Nov 4, 2025
b090a7c
add nstring into val_ncdim conditionally skip write and yes use three…
BenjaminRuston Nov 5, 2025
e7901a3
reduce integer with removal of dimension
BenjaminRuston Nov 5, 2025
aad80ac
remove another occurance of nstring
BenjaminRuston Nov 5, 2025
052c44a
swinging in the dark why does it work for stationid
BenjaminRuston Nov 5, 2025
e78418f
revert last change to define_mod
BenjaminRuston Nov 5, 2025
a3816db
conditionally only write nstring for conventional data
BenjaminRuston Nov 5, 2025
ed02915
add nstring back to dimension names
BenjaminRuston Nov 5, 2025
e63bcbe
update output for removal of nstring and attributes
BenjaminRuston Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/ncar/obs2ioda/src/ncio_mod.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,6 @@ subroutine write_obs (filedate, write_opt, outdir, itim, fileExt)
return
end if

iv = ufo_vars_getindex(name_ncdim, 'nstring')
if ( iv > 0 ) val_ncdim(iv) = nstring
iv = ufo_vars_getindex(name_ncdim, 'ndatetime')
if ( iv > 0 ) val_ncdim(iv) = ndatetime

Expand Down Expand Up @@ -154,9 +152,6 @@ subroutine write_obs (filedate, write_opt, outdir, itim, fileExt)
end do

! define global attributes
status = netcdfPutAtt(netcdfID, "min_datetime", xdata(ityp, itim)%min_datetime)
status = netcdfPutAtt(netcdfID, "max_datetime", xdata(ityp, itim)%max_datetime)

if ( allocated(xdata(ityp,itim)%wavenumber) ) then
has_wavenumber = itrue
else
Expand Down