Skip to content

move the winmsk after thinning section #1729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
weiwilliam wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

move the winmsk after thinning section #1729

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c009e9f
move the winmsk after thinning section
Dec 4, 2025
57a778c
Merge branch 'develop' into bugfix/viirs_aod2ioda
BenjaminRuston Dec 11, 2025
ee4fa8a
Merge branch 'develop' into bugfix/viirs_aod2ioda
BenjaminRuston Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/compo/viirs_aod2ioda.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,6 @@ def read(self):

# assign the observation time based on time coverage
self.obs_time = np.full(np.shape(self.lons), round(0.5*(self.s_time + self.e_time)), dtype=np.int64)
winmsk = ((self.obs_time >= self.wbeg) & (self.obs_time <= self.wend))

# apply thinning mask
if self.thin > 0.0:
Expand All @@ -311,7 +310,10 @@ def read(self):
self.qcfs = self.qcfs[mask_thin]
self.obs_time = self.obs_time[mask_thin]

# Write out data
# create the final mask for output based on time window
Copy link
Collaborator

@BenjaminRuston BenjaminRuston Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# create the final mask for output based on time window
# after the thinning above apply a mask based on time window

@mer-a-o is this the line you were referring to and did I interpret correctly please correct as needed @weiwilliam nothing else is needed correct

Copy link
Collaborator

@BenjaminRuston BenjaminRuston Dec 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, now not confused,,, looks like can commit please @weiwilliam or @mer-a-o do so if this looks like the change desired and we'll move this forward

winmsk = ((self.obs_time >= self.wbeg) & (self.obs_time <= self.wend))

# Write out data
self.outdata[('latitude', metaDataName)] = np.append(
self.outdata[('latitude', metaDataName)], np.array(self.lats[winmsk], dtype=np.float32))
self.outdata[('longitude', metaDataName)] = np.append(
Expand Down