-
Notifications
You must be signed in to change notification settings - Fork 0
JEDI-CI performance fixes #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eap
commented
Aug 12, 2025
ashley314
approved these changes
Aug 13, 2025
Collaborator
ashley314
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance improvements for
jedi-ciPart of the test-launcher container is pre-built and pushed to the github container repo. This pre-building improves the speed of the action init. We do not pre-build the full image because it would prevent testing of unsubmitted changes.
Use a thread pool to cancel batch jobs and GitHub check runs. The functions used to to cancel prior tests runs are network bound and somewhat slow. Rather than running them in serial, this change runs them in parallel with a thread pool executor (Python's GIL doesn't matter here because the latency comes from non-blocking network calls).
Why was this needed?
The JEDI-CI launcher is somewhat interactive and a failure here causes a great deal of downstream developer pain. I want this action to execute as fast as possible in order to improve the chances that a failure is noticed before the user "walks away". Additionally, this will be JCSDA's most widely used GitHub-hosted action and this will prevent it from consuming unnecessary compute time (which is "expensive" due to our limited GitHub-earmarked funding).
Checklist