-
Notifications
You must be signed in to change notification settings - Fork 9
Interpolate State to Gaussian Grid #1212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks good to me, I will wait for tests to pass before I approve it. Does this handle land mask interpolation well? |
no |
shlyaeva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll look into the test failures, I agree they are not related, so must be happening on develop as well.
@guillaumevernieres what do you mean by that? |
@shlyaeva , I guess it depends on our definition of "well". I'd say it works for most cases. |
To me that sounds unwell 😃 it's tough nut to crack though.. |
Dooruk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very well 👍🏼

Duplicate of #1057
jedi-ci-test-select=intel