Skip to content

Conversation

@guillaumevernieres
Copy link
Contributor

@guillaumevernieres guillaumevernieres commented Dec 12, 2025

Duplicate of #1057

jedi-ci-test-select=intel

@guillaumevernieres
Copy link
Contributor Author

The ci failures aren't related to this PR, the added test (converttogauss) is fine:
converttogauss

@Dooruk
Copy link
Collaborator

Dooruk commented Dec 15, 2025

Looks good to me, I will wait for tests to pass before I approve it.

Does this handle land mask interpolation well?

@guillaumevernieres
Copy link
Contributor Author

Looks good to me, I will wait for tests to pass before I approve it.

Does this handle land mask interpolation well?

no

Copy link
Collaborator

@shlyaeva shlyaeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look into the test failures, I agree they are not related, so must be happening on develop as well.

@shlyaeva
Copy link
Collaborator

Does this handle land mask interpolation well?

no

@guillaumevernieres what do you mean by that?

@guillaumevernieres
Copy link
Contributor Author

Does this handle land mask interpolation well?

no

@guillaumevernieres what do you mean by that?

@shlyaeva , I guess it depends on our definition of "well". I'd say it works for most cases.
But it doesn't work for all cases: This is related to that flooding business I was trying to push to oops a while back. What we have here will work well enough for most cases but will be off when the coastline geometry is "complex" (island, peninsula, ...) and the interpolation ends up using the wrong neighbors.

@Dooruk
Copy link
Collaborator

Dooruk commented Dec 16, 2025

@shlyaeva , I guess it depends on our definition of "well". I'd say it works for most cases. But it doesn't work for all cases: This is related to that flooding business I was trying to push to oops a while back. What we have here will work well enough for most cases but will be off when the coastline geometry is "complex" (island, peninsula, ...) and the interpolation ends up using the wrong neighbors.

To me that sounds unwell 😃 it's tough nut to crack though..

@shlyaeva shlyaeva requested a review from Dooruk December 16, 2025 18:30
Copy link
Collaborator

@Dooruk Dooruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well 👍🏼

@shlyaeva shlyaeva merged commit 15bd356 into develop Dec 16, 2025
3 checks passed
@shlyaeva shlyaeva deleted the feature/add-structured-grid branch December 16, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants