Fix compiler warnings #1221
Merged
Fix compiler warnings #1221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlyaeva
approved these changes
Jan 23, 2026
Collaborator
shlyaeva
left a comment
shlyaeva
left a comment
There was a problem hiding this comment.
Thank you @fmahebert !
svahl991
approved these changes
Jan 23, 2026
| oops::Log::info() << "updating ice state " << ensMember << ":" << ens[iens] << std::endl; | ||
| for (size_t itime = 0; itime < ens.local_time_size(); ++itime) { | ||
| ens(itime, iens) += incs[itime, iens]; | ||
| ens(itime, iens) += incs(itime, iens); |
Contributor
There was a problem hiding this comment.
Nice catch! I was unaware of the comma operator and had to go educate myself on it. Talk about functionality that seems ideal for creating difficult bugs!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some compiler warnings raised by IntelLLVM 2025.3
IncSet[a, b]evaluating toIncSet[b], but that should likely have been written asIncSet(a, b)— this one could have correctness implications!